Bug #3339

One-Shot License Analysis/Copyright page does include micro menus (part of menus does not work)

Added by larry shi 9 months ago. Updated 9 months ago.

Status:Closed Start date:09/05/2012
Priority:High Due date:
Assignee:Bob Gobeille % Done:

0%

Category:UI
Target version:2.1.0
Rank:2 Tester:

New_Picture__4_.jpg (19.3 kB) Mary Laser, 09/05/2012 06:52 pm

pre_fix.png (35.1 kB) larry shi, 09/06/2012 03:28 am

after_fix.png (36.6 kB) larry shi, 09/06/2012 03:28 am

History

Updated by Mary Laser 9 months ago

Hi Larry, which micro menus do you see on the One-Shot License Analysis page? I don't see any. I've attached my screen shot

Updated by larry shi 9 months ago

Mary Laser wrote:

Hi Larry, which micro menus do you see on the One-Shot License Analysis page? I don't see any. I've attached my screen shot

sorry, does not have any micro menus, so it does not make sense to me, :-(

Updated by larry shi 9 months ago

  • Subject changed from One-Shot License Analysis page does have micro menus to One-Shot License Analysis page does not have micro menus

Updated by larry shi 9 months ago

fixed in svn 6178.

attached are the UI screen shot, before and after this fix, if you do not agree this check, please tell me, I will revert it.

Updated by larry shi 9 months ago

  • Target version changed from installation to 2.1.0

Updated by larry shi 9 months ago

  • IterNum set to 8

Updated by Mary Laser 9 months ago

  • Status changed from Resolved to Rejected

Hi Larry, Thanks for checking on this. The One Shot License Analysis page should NOT have micro menus (see below). Please revert your changes and I will reject this issue.

<maryl> hey bobg, Larry has filed a defect against the One Shot License analysis UI page, saying that the micro menus do not show up. http://www.fossology.org/issues/3339
<maryl> It doesn't seem to me that they should. they don't in 2.0
<bobg> ok
<maryl> Do you know which is the right way?
<maryl> with or without micro menus
<bobg> let me look at 2.0, that's probably the way it should be
<maryl> there are screen captures attached to the issue
<maryl> ok, thanks. that was my reasoning, too
<bobg> the "after_fix.png is definitely wrong.
<bobg> There is no path in the yellow bar.
<bobg> WIthout that the micromenus make no sense
<maryl> k, that's my take too.
<maryl> thanks for the 2nd pair of eyes
<bobg> and since there is no browse path there can be no path in the yellow bar, therefore no micro menus
<maryl> yup

Updated by larry shi 9 months ago

bob, will confirm with bob later.

Updated by larry shi 9 months ago

  • Status changed from Rejected to Feedback
  • Assignee changed from larry shi to Bob Gobeille

why I think no micro menu do not make sense is because:
1. the same with one shot copyright analysis page
2. for one shot copyright analysis, you can see the file content of the file you want to analyze, and in the file content the copyright text will be highlighted
3. for one shot nomos analysis, I think show file content make more sense then no file content

Updated by Bob Gobeille 9 months ago

  • Status changed from Feedback to In Progress
  • Assignee changed from Bob Gobeille to larry shi

[09:40] <bobg> in oneshot copyright, click on "info"
[09:40] <bobg> or "hex"
[09:40] <larrys> you mean return to
[09:41] <bobg> they don't work
[09:41] <larrys> original page? I knnow that
[09:41] <bobg> so oneshot copyright is wrong
[09:41] <larrys> it is one problem
[09:42] <larrys> how about just show the file content, remove the micro menus?
[09:43] <bobg> yes, remove the micro menu from oneshot copyright and oneshot license
[09:43] <larrys> just keep the file content, right?
[09:43] <bobg> yes
[09:43] <larrys> ok
[09:44] <larrys> got it

Updated by larry shi 9 months ago

  • Subject changed from One-Shot License Analysis page does not have micro menus to One-Shot License Analysis/Copyright page does include micro menus (part of menus does not work)

Updated by larry shi 9 months ago

  • Status changed from In Progress to Resolved

fixed in svn 6189.

Updated by Paul Holland 9 months ago

  • Assignee changed from larry shi to Mary Laser

Updated by Mary Laser 9 months ago

  • Assignee changed from Mary Laser to Bob Gobeille
  • IterNum changed from 8 to 9

Please verify this is the correct behavior and the issue is resolved.

Updated by Bob Gobeille 9 months ago

  • Status changed from Resolved to Closed

verified on svn 6192

Also available in: Atom PDF