FOSSology

Changing to high priority per Bob. Should be something we do sooner rather than later.

Objective:
For some users (e.g. admin), for a scanned package, if the admin find that the license report of some files are incorrect, can change it.
1. Can change license data on UI, display the change of license data (click on the license data, you can see who changed what and when.
2. Change the table: license_file_ref, add 2 new fields user_fk and license_file_time
3. Change other code if needed

A medium task, 4 points

did not finish in iteration 4.

one fix in svn 6069.
Hi guys,
thanks for your testing, have fun.

Function Description: right after any license name, there is a link called ‘[Edit]’, you can click on it to change this license. On the license change page, you can change it or delete it, for now, delete has no trail; I do not have a solution to trace one deleted license. If one license is changed, when the mouse move out of this license, one license audit trail window will pop up, you can get the license audit trail information on this window.

Testing this I got an error that table license_file_audit does not exist. That file doesn't exist in core-schema.dat.

You don't need to delete a license. Just change it to license "No_license_found".

new fix in svn 6075.
it is pity, I can not test it today, because of uploadtree issues.

What uploadtree issues? The only uploadtree issue I'm aware of is that the migration of pre 2.1 uploadtree to 2.1 needs to be rewritten.

Bob Gobeille wrote:

What uploadtree issues? The only uploadtree issue I'm aware of is that the migration of pre 2.1 uploadtree to 2.1 needs to be rewritten.

yes, that is because the migration. it works now.

Testing shows PHP warnings. See attached.

Change License requires user to type in license shortname as free text. This should be a pulldown. See attached screenshot.

Tested on svn 6086, see attached .tiff for screenshot of error

fixed in svn 6089. thanks for your testing.

tested on svn 6095. Same problem as before (see 1869.tiff).

Bob Gobeille wrote:

tested on svn 6095. Same problem as before (see 1869.tiff).

I tested on your machine, and my 2 machines, can not reproduce it. perhaps we can have a talk after the meeting tomorrow.

retested on 6098 - same problem
Do you have your log level set so that you will see php Notices?

Also, where is the license audit trail?

Also, there is no link to return to the license viewer.

Bumped to iteration # 6

fixed in svn 6104.thanks for your testing.

thanks for your testing, anything please let me know.

Tested on 6104
The previous php notices are gone. That's good.

There is still a lot wrong with this from a usability standpoint. I'll send an email.

testing svn 6113, clicking on the license browser gives an undefined variable notice. See attached.

Also, on Change License, since the history of the changed license is now displayed, you don't need to display the extraneous "[Close] 'license1' is changed to 'license2'"

Also, the Change License screen could use some headings, like "Change History" and "Change License" (or something).

Also, the change license dialog should be before the change license history.

Also, change "Changed To" in the change license dialog to "Change To"

fixed in svn 6115.

tested on svn 6118

There still needs to be a way to visually separate the change dialog from the history list. I suggested using headings above. Headings alone would probably work. If not then use headings plus background coloring.

The update is still not restricted to the owner. I was able to change a license without even logging in.

The user is currently allowed to enter HTML and have it rendered in the change history. That is probably a mistake.

Changing a license will also require a bucket rescan of the file.

Changing a license will require any cached license browser pages to be removed.

fixed in svn 6152.

Please verify & close this issue AND document your step-by-step method/test for verifying this new enhancement using the manual test template (or any other test you deem necessary).
Thanks,
Mary