Bug #1749
wget_agent just use http_proxy(can not use https_proxy, ftp_proxy and no_proxy)
| Status: | Closed | Start date: | 04/06/2012 | |
|---|---|---|---|---|
| Priority: | High | Due date: | ||
| Assignee: |  Mary Laser |
% Done: | 0% |
|
| Category: | Wget agent | |||
| Target version: | 2.1.0 | Estimated time: | 8.00 hours | |
| Rank: | 2 | Tester: |
History
Updated by larry shi about 1 year ago
Hi Bob,
I have one question:
Why FOSSology have to use the proxy_server?
for wget_agent, actually downloading data via wget, we can get users set /etc/wgetrc,
if we let users set proxy in fossology.conf, wget_agent have to set the proxy again, also a little complicated?
Any suggestions?
Updated by Bob Gobeille about 1 year ago
Hi Larry,
Is this really an issue? I'm just wondering why you filed an issue with no Target version rather than asked on fossology-devel.
The main reason to have the proxy info in fossology.conf is that we can potentially use that data for commands other than wget (for example, curl). There are other minor reasons as well, for example, can we count on /etc/wgetrc in all distros, and you have to be root to edit wgetrc, and a lot of users just set http_proxy in their shell environment rather than wgetrc, ...
Updated by larry shi about 1 year ago
- Target version set to 2.0.1
Bob Gobeille wrote:
Hi Larry,
Is this really an issue? I'm just wondering why you filed an issue with no Target version rather than asked on fossology-devel.
because I am not sure if it is one defect, just want to get a clarification, so I did not set the target version.
The main reason to have the proxy info in fossology.conf is that we can potentially use that data for commands other than wget (for example, curl). There are other minor reasons as well, for example, can we count on /etc/wgetrc in all distros, and you have to be root to edit wgetrc, and a lot of users just set http_proxy in their shell environment rather than wgetrc, ...
Thanks for your clarification.
for now, wget can not use https_proxy, ftp_proxy and no_proxy, how about set the target version as 2.0.1.
Updated by Bob Gobeille about 1 year ago
Fossology-devel is the best forum to discuss if an issue should be filed or get background information.
What is the defect or enhancement you are proposing? We still want to keep the proxy info in fossology.conf.
Updated by Bob Gobeille about 1 year ago
Oh, I see. You want to change wget agent so that it can use https_proxy and ftp_proxy. Ok.
Updated by Bob Gobeille about 1 year ago
Well a really good reason to use /etc/wgetrc came up on the mailing list today. When we put http_proxy on the command line, that exposes the proxy to anyone who can view the processes on that computer. In the mailing list case they need to authenticate through their proxy:
export ftp_proxy="http://id:pwd:fqdn:port <http://proxyserver:port/> "
export http_proxy=http://id:pwd:fqdn:port <http://proxyserver:port/>
which exposes their id and password. So we need to make sure that we document using /etc/wgetrc as a way around this.
Updated by larry shi about 1 year ago
Bob Gobeille wrote:
Oh, I see. You want to change wget agent so that it can use https_proxy and ftp_proxy. Ok.
yes.
Updated by larry shi about 1 year ago
- Target version changed from 2.0.1 to 2.0.0
Bob Gobeille wrote:
Well a really good reason to use /etc/wgetrc came up on the mailing list today. When we put http_proxy on the command line, that exposes the proxy to anyone who can view the processes on that computer. In the mailing list case they need to authenticate through their proxy:
export ftp_proxy="http://id:pwd:fqdn:port <http://proxyserver:port/> "
export http_proxy=http://id:pwd:fqdn:port <http://proxyserver:port/>which exposes their id and password. So we need to make sure that we document using /etc/wgetrc as a way around this.
add this way to which document? who will do this job, mary? :-)
I changed the target version to 2.0.0.
Updated by larry shi about 1 year ago
- Target version changed from 2.0.0 to 2.0.1
I mean we should make sure that we document using /etc/wgetrc as a way around the proxy setting in 2.0, not mean will fix this defect in 2.0.0.
Updated by Bob Gobeille about 1 year ago
According to Valerie Duncan putting authentication into wgetrc still exposes it in the http request.
Updated by Paul Holland 12 months ago
- IterNum set to 2
Updated by larry shi 12 months ago
- Status changed from Resolved to In Progress
please ignore the last comment, this defect is not fixed, also need re-estimate again.
Updated by larry shi 12 months ago
- Status changed from In Progress to Resolved
fix in svn 5931 and 5900.
Updated by Mary Laser 11 months ago
- Status changed from Resolved to In Progress
Thanks for adding this new feature.
Please include unit test(s) http://fossology.svn.sourceforge.net/viewvc/fossology/trunk/fossology/src/wget_agent/agent_tests/Unit/
and/or functional test(s)
http://fossology.svn.sourceforge.net/viewvc/fossology/trunk/fossology/src/wget_agent/agent_tests/Functional/
Updated by larry shi 11 months ago
- Status changed from In Progress to Resolved
- Estimated time changed from 4.00 to 8.00
- IterNum changed from 2 to 3
checked in another fix in svn 5962, and checked in the tests in svn 5960.
just add functional tests in http://fossology.svn.sourceforge.net/viewvc/fossology/trunk/fossology/src/wget_agent/agent_tests/Functional/
unit tests for this defect fix is not suitable, have to have fossology.conf in sysconf dir.
Updated by Mary Laser 10 months ago
- Assignee changed from larry shi to Mary Laser
Mary to verify fix and close.
Updated by Mary Laser 10 months ago
- Status changed from Resolved to Closed
verified on pigwidgeon using 6098
Updated by Mary Laser 9 months ago
- Target version changed from 2.0.1 to 2.1.0