Bug #1743

./utils/ui-nomos-license-list-cli.php and ./utils/ui-copyright-list-cli.php are just quick and dirty implementation

Added by larry shi about 1 year ago. Updated 9 months ago.

Status:Closed Start date:04/06/2012
Priority:High Due date:
Assignee:Mary Laser % Done:

0%
Category:CLI
Target version:2.1.0
Rank:2 Tester:

Description

I is bad to have hardcoded paths. Also these file names shouldn't have "ui-" since they are not part of our ui. They should also be in src/cli, not /utils/. So they also don't need "cli" in their names. These two programs need a code review. The argument handling isn't good, comments are wrong, there may be duplicated code copied from the UI, the hardcoded paths, … For now, I'd put a disclaimer in the code to say that this is a quick and dirty implementation that we need to clean up.

History

#1
Updated by larry shi about 1 year ago

  • Status changed from New to In Progress

in svn 5745, 5746, moved directory and renamed files name.

#2
Updated by larry shi 10 months ago

  • Rank set to 2
  • Estimate set to 4
  • IterNum set to 7

#3
Updated by larry shi 10 months ago

  • Priority changed from Normal to High

#4
Updated by Mary Laser 9 months ago

  • Target version changed from 2.0.1 to 2.1.0

#5
Updated by larry shi 9 months ago

Larry is creating 2 commands nomos-license-list and copyright-list

#6
Updated by larry shi 9 months ago

not sure if these 2 commands need user/password authentication, will confirm with team.

#7
Updated by larry shi 9 months ago

  • Status changed from In Progress to Resolved

fixed in svn 6167.

#8
Updated by Paul Holland 9 months ago

  • Assignee changed from larry shi to Mary Laser

Resolved task needs validated before closed.

#9
Updated by Mary Laser 9 months ago

  • Status changed from Resolved to Closed

Verified with all.zip on fluffy.ostt, svn 6170

Also available in: Atom PDF