Bug #1551

mail content from mail notification is not sufficient

Added by larry shi about 1 year ago. Updated 9 months ago.

Status:Closed Start date:03/15/2012
Priority:Normal Due date:
Assignee:Alex Norton % Done:

0%
Category:Notification
Target version:2.1.0
Rank: Tester:

Description

1. it seems that
gboolean email_replace() in database.c is not finished, right?

2. for now, for one upload, multiple mails are sent out, how about merging them into one mail?

When email is sent it looks like this:

FOSSology scan has completed.

http://localhost/repo/?mod=showjobs&show=job&job=7
http://localhost/repo/?mod=browse&upload=7&show=detail
http://localhost/repo/?mod=browse&upload=7&show=detail
http://localhost/repo/?mod=browse&upload=7&show=detail
http://localhost/repo/?mod=browse&upload=7&show=detail

FOSSology
\377

There are a couple of problems with the above message:

1. Each 'sub job' is reported. As a user, I really only care about the complete job, did it finish with no errors or did it have errors?

2. Using localhost won't work. I can't actually view these items, cause they were done on randotest.ostt, not 'localhost'. If I cut and paste those links in, I get nowhere.

3. what is \377? please remove or convert to human readable.

4. It would be really nice to use the 'name' of the job in addition to the job number. Because I can read the link I know it's job 7, but some folks might not get that. Even so, I know it's job 7, hmmm which is job 7? The screen telling my it's job 7 is long gone and my recent jobs does not use job number (the number links at the left my not be recognized as the 'job number'). So what upload was that? Using the 'name' of the upload will solve this.

Maybe something like this:

FOSSology scan has completed.
The FOSSology scan of job number xx (deb-sources.11.10) has completed with no errors (or with errors as appropriate). To view the upload:

< link to the browse page >

To view the jobs associated with this upload:

http://<system.domain>/repo/?mod=showjobs&show=job&job=7

Please think about ways to make the message clearer and more useful to the user. Thanks.

History

#1
Updated by Alex Norton about 1 year ago

  • Description updated (diff)
  • Status changed from New to In Progress
  • Target version changed from 2.0.0 to 2.0.1

Most of these are going to be non starters for the time being.

1. This is not a trivial change to the scheduler. It does not currently keep track of all the jobs that belong to a particular upload. Adding that functionality will take some time and we are already pressed for time in getting the release ready. I will look into making this change for the next release. If the user is getting too many emails, they can turn the feature off.

2. This is not something inserted by the scheduler. It grabbed the url from the sysconfig table of the database. If you want the url to be usefull, you need to change it there.

3. I don't know where this comes from. As far as I can tell, it is something put there by mailx because the scheduler is not writing it to mailx. This will most likely get fixed at the same time as 1.

4. This one should be fairly easy to implement. I will look into implementing this one for FOSSology 2.0 instead of 2.0.1

#2
Updated by Bob Gobeille 12 months ago

#3 is a dup of issue 1989. Since it is a separate scheduler issue it should have its own issue number.

#1 was fixed in 2.0.0

#4 we have the upload name which is probably good enough

#3
Updated by Paul Holland 12 months ago

  • Status changed from In Progress to Resolved

This defect is fixed or has other issues that represent the defects still outstanding. Closing.

#4
Updated by larry shi 10 months ago

  • Status changed from Resolved to Feedback

test in svn 6092 on debian 6.0/64bit.

From Fri Jul 27 16:28:35 2012
Return-Path: <>
X-Original-To: fossy
Delivered-To:
Received: by bl460c-10.test (Postfix, from userid 116)
id E08983080C3; Fri, 27 Jul 2012 16:28:35 +0800 (CST)
To:
Subject: FOSSology scan complete
Message-Id: <>
Date: Fri, 27 Jul 2012 16:28:35 +0800 (CST)
From: (fossology)

FOSSology scan has completed.

hello.7z
http://bl460c-10/repo/?mod=browse&upload=2&item=2&show=detail
http://bl460c-10/repo/?mod=showjobs&upload=2
http://bl460c-10/repo/?mod=showjobs&show=job&job=11
Software Repository
[NOT IMPLEMENTED]

FOSSology
ÿ

I am not sure if this defect is fixed, you know
1) [NOT IMPLEMENTED], what does this line mean?
2) the last line ÿ, still incorrect, right?

#5
Updated by Alex Norton 10 months ago

  • Status changed from Feedback to Closed

We closed this defect because the issues are not a show stopper and there are much high priority items atm. This issue http://www.fossology.org/issues/1989 is the replacement for the remain problems that still remain with the notification email.

I'm closing this.

#6
Updated by Mary Laser 9 months ago

  • Target version changed from 2.0.1 to 2.1.0

Also available in: Atom PDF